Add csv-delimiter #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please only use the |
Kerollmops
requested changes
Sep 6, 2024
| pub fn new(file: PathBuf, size: usize, delimiter: Option<char>) -> Result<Self> { | ||
| let mut reader_builder = ReaderBuilder::new(); | ||
| if let Some(delim) = delimiter { | ||
| reader_builder.delimiter(delim as u8); |
There was a problem hiding this comment.
Can you do a try_into instead? By using .context("your error") you can return an error for when a character cannot be represented as a single byte.
|
I close this PR as I brought the support of CSV delimiters on main directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #<issue_number>
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!