-
Notifications
You must be signed in to change notification settings - Fork 315
Move to Uniffi 0.29, adjust async callback macros #5080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f783222
to
0c20635
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5080 +/- ##
=======================================
Coverage 85.83% 85.83%
=======================================
Files 333 333
Lines 36158 36158
=======================================
+ Hits 31035 31037 +2
+ Misses 5123 5121 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e61d4d6
to
5169e21
Compare
This commit completes the uniffi upgrade from 0.28.0 to 0.29.1 and establishes the infrastructure for async callbacks in WASM32 environments. Key changes: - Upgrade uniffi to 0.29.1 with git source for async callback support - Fix FFI macros to use smart async runtime selection for WASM32 vs native - Update tokio features across matrix-sdk crates for WASM32 compatibility - Add TypeScript bindings configuration to uniffi.toml - Fix xtask build system for uniffi 0.29 API changes
5169e21
to
76aecab
Compare
Looks like the uniffi-go tool that is being used has been semi-abandoned by the maintainers. Curious what you recommend doing in this situation. |
Huh? Are we talking about the same thing? We're using |
Yes that repo -- I was reading an issue talking about a past uniffi upgrade, and the maintainers said "PRs welcome but we have no planned updates" I had claude code take a crack at the upgrade to 0.29.2 here NordSecurity/uniffi-bindgen-go#77, we will see what they think. |
Also contains matrix-sdk-common changes from #5079
Signed-off-by: Daniel Salinas