Skip to content

Conversation

@satishashilwar
Copy link

@satishashilwar satishashilwar commented Dec 15, 2025

  • Modified _initOldCustomOptions() to include sort_order in existing option data
  • Enhanced _findExistingOptionId() to match by type + sort_order first, then fallback to title matching
  • This ensures options with same structure but different store titles are recognized as translations
  • Fixes issue where multi-store CSV imports created duplicate options instead of proper translations

The fix maintains backward compatibility by keeping title-based matching as fallback.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix #13983: Improve custom option matching for multi-store imports #40369: Fix Import custom option by CSV for multi store view #13983: Improve custom option matching for multi-store imports

…orts

- Modified _initOldCustomOptions() to include sort_order in existing option data
- Enhanced _findExistingOptionId() to match by type + sort_order first, then fallback to title matching
- This ensures options with same structure but different store titles are recognized as translations
- Fixes issue where multi-store CSV imports created duplicate options instead of proper translations

The fix maintains backward compatibility by keeping title-based matching as fallback.
@m2-assistant
Copy link

m2-assistant bot commented Dec 15, 2025

Hi @satishashilwar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@satishashilwar
Copy link
Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento create issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

[Issue] Fix #13983: Improve custom option matching for multi-store imports Import custom option by CSV for multi store view

2 participants