Skip to content

Fixed bad format of placeholder string for #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andsel
Copy link
Contributor

@andsel andsel commented May 22, 2025

Fixes a typo

@andsel andsel self-assigned this May 22, 2025
@@ -117,7 +117,7 @@ To override this, set this to something like "32.0" for example.

The filter to add to the Salesforce query when a previous tracking field value
was read from the <<plugins-{type}s-{plugin}-tracking_field_value_file>>.
The string can (and should) contain a placeholder `%+{last_tracking_field_value}+` that

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andsel. FYI: I've already made the corresponding fix in the MD output. This PR will ensure that my changes won't get stomped. Thank you!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @andsel and @karenzone ! My AsciiDoc previewer seemed to think the + escapes were necessary here but I'll trust your guidance on this :-)

@andsel andsel requested a review from fransflippo May 22, 2025 15:27
@fransflippo fransflippo merged commit 508f83f into logstash-plugins:main May 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants