-
Notifications
You must be signed in to change notification settings - Fork 30
Added array of sObjects and run at interval support #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added continuous run option based on an interval.
@ppf2 Are you going to fix this build and merge PR? I need salesforce data refreshing. |
Hi all, any reason this hasn't been merged yet? Would be a lot more convenient if it was part of the official plugin that you install with I'm thinking it probably makes sense to split this into 2 PRs? One to add the |
Hi @fransf-wtax . I'm not directly involved with managing Logstash plugins but @jsvd @flexitrev should be able to help. |
Hi All, |
Hi @qury , @jsvd gave me access a while back as the project had become more or less owner-less and I had the intention to try and get some of the changes like this one out in an official release, however I got a bit stuck and then other things took over. I'll have another look at this in the coming weeks. |
@fransf-wtax |
Hey @qury , sorry, no. Thanks for the reminder :)
Hope to get a 3.3.0 of this plugin out by the end of this week. I'll comment the link to the new pull request once I have it and then close this one. |
@qury I've added the functionality to a new branch and opened a PR for it: #37. Do you want to have a look at it and see if the change would work for you like this? Otherwise I'll release later this week. I'll also include #38 in that release which adds incremental data loading, which will be useful for objects with lots of records of which most don't change a lot, and for preventing duplicates when running the plugin multiple times or on a schedule. |
I've released version 3.3.0 of the plugin which now contains the interval support from #37. I don't see the value of the multiple sObjects part of this PR: you can easily have two instances of the plugin in your Logstash pipeline, one for each object, which as far as I can tell achieves the exact same thing, albeit with slightly more configuration. |
The original author of this plugin intended to provide support to fetch an array of sObjects (#4) and an option to run on an interval (continuously). Some of this code got lost and was never merged into this repository. This is an attempt to add them back.
@acchen97 @suyograo