[cmake] Don't generate per-file "__SHORT_FILE__" defines on visual studio builds

[RKSimon]

As reported on #150677 - this is preventing msbuild parallelization as cmake is repeatedly being updated

[joker-eph]

Can you provide more info on the "repeated cache generation" aspect? You mentioned before that the build would come to a halt which seems a bit different than a cache problem?
At least link to the discussion on the original PR maybe?

It's not clear to me that someone reading this right now would even connect the dots to MSBuild-specific issue.

[RKSimon]

I don't know enough about how cmake does its thing on visual studio - is it possible it gets run multiple times or something during the build? All I know is #150677 slowed everything to a crawl.

[joker-eph]

I mean you refer to a "cache", which cache? In general I think of "ccache" when I read this. If you mean that this triggers repeated cmake invocation, then why not write it as is?
You likely should be able to see which process is churning why things seem slow? If cmake is re-running that should be visible, and there should be no compilation job running concurrently?

[joker-eph]

The update message may be good enough for now, I hope this isn't setting up a Chesterton's Fence though!

[compnerd]

The commit summary is a bit confusing - it doesn't impact MSVC builds, it impacts the VS generator.

[RKSimon]

Yes, it demonstrates my lack of understanding of what actually goes on in cmake vs builds - all I can see is that there is at most 2 cores being used for cl.exe and cmake.exe keeps reappearing as well.