fix(transport): improve WebSocket/WebRTC connection robustness #3222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this PR. Is this in response to an issue you’ve seen in a deployed application or are you just trying to make general improvements to the codebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3221
Description
This PR improves the robustness of WebSocket and WebRTC connection establishment by adding proper error handling, timeouts, and retry mechanisms.
Changes
WebSocket Transport
Added retry mechanism (max 3 attempts with 1s delay)
Added connection timeout handling
Improved error handling with detailed error messages
Added connection state tracking
Added metrics for failure scenarios
WebRTC Transport
Added ICE gathering timeout (30s)
Added overall connection timeout (60s)
Added SDP answer timeout
Added connection state monitoring
Improved cleanup of event listeners
Added metrics for different failure scenarios
Testing
Tested connection establishment under poor network conditions
Verified retry mechanism works as expected
Confirmed proper cleanup after failed connections
Checked metrics are correctly reported
Related Issues
Closes #3221