Skip to content

[12.x] Pass LoggerInterface when constructing RoundrobinTransport instance #56244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 12.x
Choose a base branch
from
Draft

[12.x] Pass LoggerInterface when constructing RoundrobinTransport instance #56244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Mail/MailManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@
: $this->createSymfonyTransport($config);
}

return new $class($transports, $config['retry_after'] ?? 60);
return new $class($transports, $config['retry_after'] ?? 60, $this->app->make(LoggerInterface::class));

Check failure on line 430 in src/Illuminate/Mail/MailManager.php

View workflow job for this annotation

GitHub Actions / Source Code 

Class Symfony\Component\Mailer\Transport\RoundRobinTransport constructor invoked with 3 parameters, 1-2 required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such changes need to be PRed to master branch for the Laravel 13 release?

Laravel 12 still needs to support Symfony 7.3 and lower unless composer.json specifically set to only support 7.4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will still be compatible with older Symfony versions, given that passing additional parameters to a constructor is allowed in PHP (they're just discarded).

So this change is backwards compatible and will only effectively do something for those actually using 7.4+.

}

/**
Expand Down
Loading