perf(l2): avoid cloning all fields from ExecutionWitnessResult #3765
+228
−152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When proving a large batch performance was being affected because we were cloning the entire ExecutionWitnessResult struct, this meant cloning all the BlockHeaders, Code and ChainConfig for every block.
Description
Perf Metrics
command:
specs:
commits:
This branch (commit 16420ed)
Main (commit ce5c47d)
Main:
Elapsed: 147.28s
This branch:
Elapsed: 67.07s
Main: https://share.firefox.dev/3H2Hd5A
This branch: https://share.firefox.dev/40yeDzP