feat(l2): always use monitor #3759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the --monitor flag from the L2 sequencer configuration and enables the monitor functionality by default. The change simplifies the codebase by eliminating conditional monitoring behavior once all monitor-related issues have been resolved.
- Removes the
--monitorCLI flag and related configuration options - Updates the monitoring initialization to run unconditionally
- Simplifies tracing initialization by removing monitor-specific conditional logic
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
crates/l2/sequencer/mod.rs |
Removes conditional check for monitor enabling, making EthrexMonitor always spawn |
crates/l2/sequencer/configs.rs |
Removes the enabled field from MonitorConfig struct |
cmd/ethrex/l2/options.rs |
Removes the --monitor CLI flag and its configuration mapping |
cmd/ethrex/l2/initializers.rs |
Simplifies tracing initialization by removing monitor-conditional logic |
cmd/ethrex/l2/command.rs |
Updates function call to match simplified tracing initialization |
cmd/ethrex/l2/initializers.rs
Outdated
| @@ -18,7 +18,7 @@ use tracing_subscriber::layer::SubscriberExt; | |||
| use tui_logger::{LevelFilter, TuiTracingSubscriberLayer}; | |||
|
|
|||
| use crate::cli::Options as L1Options; | |||
| use crate::initializers::{self, get_authrpc_socket_addr, get_http_socket_addr}; | |||
| use crate::initializers::{get_authrpc_socket_addr, get_http_socket_addr}; | |||
There was a problem hiding this comment.
The removal of the initializers import alias may indicate that some functionality from that module is no longer being used. Consider verifying that all necessary imports are still present after removing the monitor-conditional logic.
Copilot uses AI. Check for mistakes.
Lines of code reportTotal lines added: Detailed view |
ilitteri
requested changes
Jul 29, 2025
github-project-automation
bot
moved this from In Review
to Requires Changes
in ethrex_l2
ilitteri
approved these changes
Jul 31, 2025
tomip01
approved these changes
Jul 31, 2025
Oppen
pushed a commit
that referenced
this pull request
Aug 1, 2025
**Motivation** Once all monitor issues are resolved, it should be used by default <!-- Why does this pull request exist? What are its goals? --> **Description** Change the `--monitor` flag for the `--no-monitor` one, which turns off the monitor <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> It should only be merged after all other issues are resolved #3513, #3526, #3534, #3516, #3520, #3521, #3522, #3523, #3524, #3525, #3527, #3528, #3529, #3530, #3531, #3532, #3695, #3757, #3736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Once all monitor issues are resolved, it should be used by default
Description
Change the
--monitorflag for the--no-monitorone, which turns off the monitorIt should only be merged after all other issues are resolved
#3513, #3526, #3534, #3516, #3520, #3521, #3522, #3523, #3524, #3525, #3527, #3528, #3529, #3530, #3531, #3532, #3695, #3757, #3736