Skip to content

refactor(l2): remove the dev_mode CLI option and infer dev mode from on‑chain proof getters #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

julienbrs
Copy link

Motivation

“dev mode” is now simply the case where the on‑chain proposer contract returns only the DEV_MODE_ADDRESS for all proof getters, in which case we fall back to the Exec prover. Removing the CLI option shifts the truth to on‑chain configuration.

Description

  • Remove the dev_mode field from all L2 CLI structs and configs.
  • Delete all code paths that branched on the old flag.
  • Update get_needed_proof_types to always call the on‑chain getters for every ProverType and collect those whose addresses differ from DEV_MODE_ADDRESS. If the resulting list is empty, return vec![ProverType::Exec] as the implicit dev‑mode fallback.

Closes #3698

@julienbrs julienbrs requested a review from a team as a code owner July 20, 2025 21:24
@ManuelBilbao ManuelBilbao added the L2 Rollup client label Jul 21, 2025
@ilitteri ilitteri moved this to In Review in ethrex_l2 Jul 29, 2025
Copy link
Contributor

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @julienbrs!
Thanks for the contribution, and sorry for the delay in reviewing it. I've left one comment that needs to be addressed.

@github-project-automation github-project-automation bot moved this from In Review to Requires Changes in ethrex_l2 Jul 29, 2025
@julienbrs
Copy link
Author

Thanks for the review @avilagaston9, I’ve restored the original variable names, should be good now

@julienbrs julienbrs requested a review from avilagaston9 July 31, 2025 07:54
Copy link
Contributor

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove ETHREX_PROOF_COORDINATOR_DEV_MODE from the entire codebase, including all places where it is set, as well as from the documentation.

@julienbrs julienbrs requested a review from avilagaston9 August 2, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L2 Rollup client
Projects
Status: Requires Changes
Development

Successfully merging this pull request may close these issues.

L2: remove the dev_mode L2 CLI option
3 participants