-
Notifications
You must be signed in to change notification settings - Fork 87
refactor(l2): remove the dev_mode CLI option and infer dev mode from on‑chain proof getters #3739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor(l2): remove the dev_mode CLI option and infer dev mode from on‑chain proof getters #3739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @julienbrs!
Thanks for the contribution, and sorry for the delay in reviewing it. I've left one comment that needs to be addressed.
Thanks for the review @avilagaston9, I’ve restored the original variable names, should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove ETHREX_PROOF_COORDINATOR_DEV_MODE
from the entire codebase, including all places where it is set, as well as from the documentation.
Motivation
“dev mode” is now simply the case where the on‑chain proposer contract returns only the
DEV_MODE_ADDRESS
for all proof getters, in which case we fall back to the Exec prover. Removing the CLI option shifts the truth to on‑chain configuration.Description
get_needed_proof_types
to always call the on‑chain getters for every ProverType and collect those whose addresses differ fromDEV_MODE_ADDRESS
. If the resulting list is empty, returnvec![ProverType::Exec]
as the implicit dev‑mode fallback.Closes #3698