feat: add stopping stage update run implementation #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britaniar
force-pushed
the
stopUpdateRun
branch
from
040bf28 to
878fa65
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
britaniar
force-pushed
the
stopUpdateRun
branch
from
878fa65 to
723e9c9
Compare
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
britaniar
force-pushed
the
stopUpdateRun
branch
from
723e9c9 to
4bee175
Compare
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Arvindthiru
reviewed
Dec 11, 2025
Arvindthiru
reviewed
Dec 11, 2025
Arvindthiru
reviewed
Dec 11, 2025
Arvindthiru
reviewed
Dec 12, 2025
Arvindthiru
reviewed
Dec 12, 2025
Arvindthiru
reviewed
Dec 12, 2025
Arvindthiru
reviewed
Dec 12, 2025
jwtty
reviewed
Dec 12, 2025
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Arvindthiru
reviewed
Dec 12, 2025
Arvindthiru
reviewed
Dec 12, 2025
Arvindthiru
reviewed
Dec 12, 2025
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
Added a check to make sure no cluster start updating and let currently updating cluster finish within a stage before marking the stage and update run as stopped.
Update the stage condition status as stopping or stopped.
Update integration tests and added UTs.
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
While waiting for cluster to finish updating, stage and update run will have a progressing unknown condition with the reason as stopping.