Bzip3 #673
Bzip3 #673
Conversation
|
Hm. seems something went wrong when pushing. |
archive/bzip3.ksy
Outdated
| size: len_compressed | ||
| instances: | ||
| is_last: | ||
| value: len_uncompressed < _root.header.block_size |
There was a problem hiding this comment.
Are you sure about this? Can you back it up with a link to https://github.com/kspalaiologos/bzip3 as a source, perhaps?
There was a problem hiding this comment.
The bzip3 doesn't take concatenated files into account but will just try to continue. For my particular use case (where I need to be able to carve) it is actually important. So no, it isn't in the specification.
There was a problem hiding this comment.
Could you please explain this in a doc somewhere why this .ksy spec does this while the reference implementation does not? Because it's confusing at least.
There was a problem hiding this comment.
Yes, it is a bit confusing, and it also doesn't work in all cases (so I need to work a bit more on expanding the specification). Would you prefer if I would first add additional block parsing?
This PR adds some support for the bzip3 format. It is limited to structural checks (header and chunks) but no decompression is done.