feat(core): Add support for partial auth in proxy payments [V2] #9503

srujanchikke · 2025-09-23T06:59:40Z

Type of Change

Description

This PR adds support for partial auth in proxy payments which is triggered in revenue recovery workflow.
enable_partial_authorization is passed in /recovery flow, which update payment intent with enable_partial_authorization to true. Proxy(authorize) will gets triggered by recovery execute workflow, which will then send the same to connector. Based on amount_captured send by connector we either move the payment to success/ PartialCharged.

NOTE : changes are still pending for normal payments partial auth.

This PR also contains few changes regarding revenue recovery workflow where we consider PartialCharged payments as Succeeded. We will the resume later when auto retries system is enabled for partial charged payments.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Reference doc for partial auth testing via worldpay vantiv : http://support.worldpay.com/support/CNP-API/content/testauthincind.htm#TABLE2-1
TEST CASE 1 :
set up revenue recovery payment and billing mca with worldpay vantiv and billing mca

curl --location 'http://localhost:8080/v2/connector-accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'x-merchant-id: cloth_seller_lPcOqukU9cZQLwpuwleD' \
--header 'x-profile-id: pro_dzQ31gKcfnWgaNQVOkvA' \
--header 'Authorization: admin-api-key=test_admin' \
--data '{
    "connector_type": "payment_processor",
    "connector_name": "worldpayvantiv",
    "connector_account_details": { 
        "auth_type": "SignatureKey",
        "api_key": "", 
        "key1": "", 
        "api_secret": "" 
    },
    "payment_methods_enabled": [
        {
            "payment_method_type": "card",
            "payment_method_subtypes": [
                {
                    "payment_method_subtype": "credit",
                    "payment_experience": null,
                    "card_networks": [
                        "Visa",
                        "Mastercard"
                    ],
                    "accepted_currencies": null,
                    "accepted_countries": null,
                    "minimum_amount": -1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_subtype": "debit",
                    "payment_experience": null,
                    "card_networks": [
                        "Visa",
                        "Mastercard"
                    ],
                    "accepted_currencies": null,
                    "accepted_countries": null,
                    "minimum_amount": -1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        }
    ],
    "frm_configs": null,
    "connector_webhook_details": {
        "merchant_secret": ""
    },
    "metadata": {
        "report_group": "Hello",
        "merchant_config_currency": "USD"
    },
    "profile_id": "pro_dzQ31gKcfnWgaNQVOkvA"
}'

curl --location 'http://localhost:8080/v2/connector-accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'x-merchant-id: cloth_seller_lPcOqukU9cZQLwpuwleD' \
--header 'x-profile-id: pro_dzQ31gKcfnWgaNQVOkvA' \
--header 'Authorization: admin-api-key=test_admin' \
--header 'api-key: test_admin' \
--data '{
    "connector_type": "billing_processor",
    "connector_name": "custombilling",
    "connector_account_details": {
        "auth_type": "NoKey"
    },
    "feature_metadata" : {
        "revenue_recovery" : {
            "max_retry_count" : 9,
            "billing_connector_retry_threshold" : 0,
            "billing_account_reference" :{
                "mca_K59DLF4m29U4Mt281n16" : "mca_K59DLF4m29U4Mt281n16"
            },
            "switch_payment_method_config" : {
                "retry_threshold" : 0,
                "time_threshold_after_creation": 0
            }
        }
    },
    "profile_id": "pro_dzQ31gKcfnWgaNQVOkvA"
}'

Trigger failed invoice

curl --location 'http://localhost:8080/v2/payments/recovery' \
--header 'Authorization: api-key=dev_35ephsVynvWKco4X3E6tv0hVNZRhbxm6H141PpqctRlQJ4x59iiuAFqcQhYoC7xd' \
--header 'x-profile-id: pro_dzQ31gKcfnWgaNQVOkvA' \
--header 'x-merchant-id: cloth_seller_lPcOqukU9cZQLwpuwleD' \
--header 'Content-Type: application/json' \
--data '{
    "amount_details": {
        "order_amount": 50000,
        "currency": "USD"
    },
    "merchant_reference_id": "ref_id63",
    "connector_transaction_id": "trans63",
    "connector_customer_id": "cust63",
    "error": {
        "code": "148",
        "message": "Invalid or expired card"
    },
    "enable_partial_authorization" : true,
    "billing": {
        "address": {
            "state": "CA",
            "country": "US"
        }
    },
    "payment_method_type": "card",
    "payment_method_sub_type": "credit",
    "payment_method_data": {
        "primary_processor_payment_method_token": "271349160840009",
        "additional_payment_method_info": {  
            "card_exp_month": "04",
            "card_exp_year": "50",
            "last_four_digits": "0009",
            "card_network": "AMEX",
            "card_issuer": "Wells Fargo",
            "card_type": "debit"
        }
    },
    "billing_started_at": "2024-05-29T08:10:58Z",
    "transaction_created_at": "2024-05-29T08:10:58Z",
    "attempt_status": "failure",
    "action": "schedule_failed_payment",
    "billing_merchant_connector_id": "mca_K59DLF4m29U4Mt281n16",
    "payment_merchant_connector_id": "mca_qM54E3Zn9iIRRGYCe2br",
    "metadata": {
        "BudgetPayId": "TEST_1234"
    }
}'

-> Pass enable_partial_authorization to false , this should make payment succeeded/Fail.
-> Pass enable_partial_authorization to true and pass normal card which will debit complete amount.

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-09-23T06:59:43Z

Review changes with

Changed Files

File	Status
crates/hyperswitch_domain_models/src/router_request_types.rs	72% smaller
crates/router/src/services/kafka/payment_intent.rs	58% smaller
crates/router/src/services/kafka/payment_intent_event.rs	58% smaller
crates/hyperswitch_connectors/src/connectors/nuvei/transformers.rs	48% smaller
crates/hyperswitch_domain_models/src/payments.rs	44% smaller
crates/router/src/core/payments/transformers.rs	41% smaller
crates/router/src/core/revenue_recovery/transformers.rs	40% smaller
crates/diesel_models/src/payment_intent.rs	31% smaller
crates/hyperswitch_domain_models/src/router_data.rs	27% smaller
crates/router/src/connector/utils.rs	19% smaller
crates/api_models/src/payments.rs	16% smaller
crates/hyperswitch_connectors/src/connectors/worldpayvantiv/transformers.rs	1% smaller
api-reference/v1/openapi_spec_v1.json	0% smaller
api-reference/v2/openapi_spec_v2.json	0% smaller
crates/common_types/src/primitive_wrappers.rs	0% smaller
crates/hyperswitch_connectors/src/connectors/chargebee/transformers.rs	0% smaller
crates/hyperswitch_connectors/src/connectors/stripebilling/transformers.rs	0% smaller
crates/hyperswitch_domain_models/src/payments/payment_intent.rs	0% smaller
crates/hyperswitch_domain_models/src/revenue_recovery.rs	0% smaller
crates/router/src/core/payment_methods.rs	0% smaller

hrithikesh026 · 2025-09-24T05:45:47Z

crates/api_models/src/payments.rs

    pub merchant_connector_details: Option<common_types::domain::MerchantConnectorAuthDetails>,
+
+    /// Allow partial authorization for this payment
+    pub enable_partial_authorization: Option<bool>,


Introduce a wrapper type for this bool.
Refer to RequestIncrementalAuthorization

hrithikesh026 · 2025-09-25T10:56:47Z

crates/common_utils/src/types/primitive_wrappers.rs

+        Clone, Copy, Debug, Eq, PartialEq, Serialize, Deserialize, diesel::expression::AsExpression,
+    )]
+    #[diesel(sql_type = diesel::sql_types::Bool)]
+    pub struct EnablePartialAuthorizationBool(bool);


You don't need to define in two places

removed this

hrithikesh026 · 2025-09-25T10:59:18Z

crates/hyperswitch_connectors/src/connectors/nuvei/transformers.rs

    fn get_is_partial_approval(&self) -> Option<PartialApprovalFlag> {
        self.enable_partial_authorization
-            .map(PartialApprovalFlag::from)
+            .map(|partial_auth| PartialApprovalFlag::from(partial_auth.is_true()))


You can have from implementation on PartialApprovalFlag.
PartialApprovalFlag::from(EnablePartialAuthorizationBool).

This change can be eliminated

hrithikesh026 · 2025-09-25T11:02:32Z

crates/router/src/core/revenue_recovery/types.rs

                Self::ReviewForFailedPayment(attempt_triggered_by)
            }
-            (enums::IntentStatus::Succeeded, _, _) => Self::ReviewForSuccessfulPayment,
+            (enums::IntentStatus::Succeeded | enums::IntentStatus::PartiallyCaptured, _, _) => {


Why only succeded and partially_captiured?

hrithikesh026 · 2025-09-25T11:04:49Z

crates/router/src/core/revenue_recovery/types.rs

+            (enums::IntentStatus::Succeeded | enums::IntentStatus::PartiallyCaptured, _, _) => {
+                Self::ReviewForSuccessfulPayment
+            }


Suggested change

(enums::IntentStatus::Succeeded | enums::IntentStatus::PartiallyCaptured, _, _) => {

Self::ReviewForSuccessfulPayment

}

(intent_status, _, _) => {

if intent_status.some_impl_function(){

Self::ReviewForSuccessfulPayment

}

else{

Self::InvalidDecision

}

}

hrithikesh026 · 2025-09-25T11:06:43Z

crates/hyperswitch_domain_models/src/payments/payment_intent.rs

@@ -1,3 +1,4 @@
+use common_types::primitive_wrappers::EnablePartialAuthorizationBool;


Suggested change

use common_types::primitive_wrappers::EnablePartialAuthorizationBool;

use common_types::primitive_wrappers;

hrithikesh026 · 2025-09-25T11:07:16Z

crates/hyperswitch_domain_models/src/payments/payment_intent.rs

    pub payment_channel: Option<common_enums::PaymentChannel>,
    pub feature_metadata: Option<Secret<serde_json::Value>>,
-    pub enable_partial_authorization: Option<bool>,
+    pub enable_partial_authorization: Option<EnablePartialAuthorizationBool>,


Suggested change

pub enable_partial_authorization: Option<EnablePartialAuthorizationBool>,

pub enable_partial_authorization: Option< primitive_wrappers::EnablePartialAuthorizationBool>,

Chikke Srujan added 2 commits September 23, 2025 12:26

add support for partial auth in proxy flow

c563009

remove v2 configs

3417e8d

srujanchikke requested review from a team as code owners September 23, 2025 06:59

srujanchikke changed the title ~~feat(Add support for partial auth in proxy payments r~~ feat(core): Add support for partial auth in proxy payments [V2] Sep 23, 2025

srujanchikke self-assigned this Sep 23, 2025

srujanchikke added A-core Area: Core flows api-v2 A-payments Area: payments labels Sep 23, 2025

Chikke Srujan and others added 3 commits September 23, 2025 12:33

remove unnecessary comments

cafd04d

chore: run formatter

1e3d3d1

docs(openapi): re-generate OpenAPI specification

fb6560b

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Sep 23, 2025

Chikke Srujan and others added 6 commits September 24, 2025 09:17

fix partial charged status

db9d921

minor fix

3d72a81

chore: run formatter

7b8ef96

add feature flag

8a0df16

refactor get captured amount for authorize flow

eefb98d

clippy fix

d83b90d

hrithikesh026 requested changes Sep 24, 2025

View reviewed changes

AkshayaFoiger previously approved these changes Sep 24, 2025

View reviewed changes

resolve comments

0e4d281

srujanchikke dismissed AkshayaFoiger’s stale review via 0e4d281 September 25, 2025 10:53

Chikke Srujan and others added 2 commits September 25, 2025 16:25

remove impls for common utils

f726fbb

Merge branch 'main' into partial_auth_in_v2

0b89e6b

hrithikesh026 reviewed Sep 25, 2025

View reviewed changes

Chikke Srujan and others added 3 commits September 26, 2025 11:37

resolve comments

02cab10

chore: run formatter

bb1af7b

docs(openapi): re-generate OpenAPI specification

6573fc3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(core): Add support for partial auth in proxy payments [V2] #9503

feat(core): Add support for partial auth in proxy payments [V2] #9503

Uh oh!

srujanchikke commented Sep 23, 2025 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Sep 23, 2025 •

edited

Loading

Uh oh!

hrithikesh026 Sep 24, 2025

Uh oh!

hrithikesh026 Sep 25, 2025

Uh oh!

srujanchikke Sep 25, 2025

Uh oh!

hrithikesh026 Sep 25, 2025

Uh oh!

hrithikesh026 Sep 25, 2025

Uh oh!

hrithikesh026 Sep 25, 2025

Uh oh!

hrithikesh026 Sep 25, 2025

Uh oh!

hrithikesh026 Sep 25, 2025

Uh oh!

Uh oh!

		@@ -1,3 +1,4 @@
		use common_types::primitive_wrappers::EnablePartialAuthorizationBool;

	use common_types::primitive_wrappers::EnablePartialAuthorizationBool;
	use common_types::primitive_wrappers;

	pub enable_partial_authorization: Option<EnablePartialAuthorizationBool>,
	pub enable_partial_authorization: Option< primitive_wrappers::EnablePartialAuthorizationBool>,

feat(core): Add support for partial auth in proxy payments [V2] #9503

Are you sure you want to change the base?

feat(core): Add support for partial auth in proxy payments [V2] #9503

Uh oh!

Conversation

srujanchikke commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

srujanchikke commented Sep 23, 2025 •

edited

Loading

semanticdiff-com bot commented Sep 23, 2025 •

edited

Loading