-
Notifications
You must be signed in to change notification settings - Fork 932
Create food_tour_workflow.yaml #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
This is yaml file which contain actual code
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to b527f0c in 1 minute and 25 seconds. Click for details.
- Reviewed
49
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. food_tour_workflow.yaml:1
- Draft comment:
Consider matching the workflow name with the file name for consistency. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% This is a style/naming suggestion that doesn't affect functionality. While consistency is good, this seems like a minor issue. The current name is clear and descriptive. Without seeing other workflow files or naming conventions, we can't be certain this is even inconsistent with the codebase's standards. The comment could be valid if there's a strict naming convention in the codebase. The suggestion might improve maintainability. Without seeing other files or documented conventions, this is a speculative style suggestion rather than a clear issue requiring change. Delete the comment as it's a minor naming suggestion without clear evidence of violating any conventions, and the current name is perfectly functional.
Workflow ID: wflow_qz57Lr14GGw52bMX
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
- id: search_restaurants | ||
tool: brave_search | ||
input: | ||
query: "top-rated restaurants in ${city} serving ${search_dishes.output}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure output type consistency for 'search_dishes.output'
; it’s used as an entire array later but here interpolated as a string.
query: "top-rated restaurants in ${city} serving ${search_dishes.output}" | |
query: "top-rated restaurants in ${city} serving ${search_dishes.output[0]}" |
input: | ||
prompt: | | ||
Plan a one-day foodie tour in ${city}: | ||
- Breakfast: ${search_dishes.output[0]} at ${search_restaurants.output[0]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider handling cases where the outputs may have fewer than 3 items to avoid out-of-bound indexing.
User description
This is yaml file which contain actual code
PR Type
enhancement
Description
Introduces a workflow for planning foodie tours across cities
Integrates weather, dish, and restaurant search steps per city
Uses LLM to recommend dining type and generate tour plan
Changes walkthrough 📝
food_tour_workflow.yaml
Introduce foodie tour planning workflow YAML
food_tour_workflow.yaml
generation.
Important
Adds
food_tour_workflow.yaml
to plan a foodie tour using weather, dining preferences, and restaurant searches.food_tour_workflow.yaml
to define a foodie tour planning workflow.for_each
loop to iterate overcities
array from input.get_weather
: Fetches weather for each city usingweather
tool.decide_dining_type
: Determines dining type (indoor/outdoor) usingllm
based on weather.search_dishes
: Searches for 3 iconic dishes in each city usingbrave_search
.search_restaurants
: Finds top-rated restaurants serving the dishes usingbrave_search
.generate_foodie_tour
: Plans a one-day tour with meal suggestions usingllm
.This description was created by
for b527f0c. You can customize this summary. It will automatically update as commits are pushed.