-
Notifications
You must be signed in to change notification settings - Fork 931
Add metrics scraping for additional services #1424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add metrics scraping for additional services #1424
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 2b77843 in 48 seconds. Click for details.
- Reviewed
81
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. monitoring/README.md:52
- Draft comment:
Consider updating the README to mention the additional 'managed' endpoints (e.g. temporal-managed, litellm-managed) if they are intended to be scraped, to ensure consistency with the Prometheus config. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment suggests updating the README, which is not allowed according to the rules. It does not provide a specific code suggestion or ask for a test to be written. It is purely informative and suggests ensuring consistency, which is not allowed.
2. monitoring/prometheus/config/prometheus.yml:15
- Draft comment:
Consider using YAML anchors or a shared configuration snippet to DRY common fields (scrape_interval, scrape_timeout, metrics_path, scheme, follow_redirects) across scrape jobs. - Reason this comment was not posted:
Confidence changes required:50%
<= threshold50%
None
Workflow ID: wflow_qZJycnGvDunyohCd
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
17693055 | Triggered | JSON Web Token | 3e9d8ae | cli/tests/test_auth.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
User description
Summary
Testing
ruff format
ruff check
PR Type
enhancement, documentation
Description
Add Prometheus scrape jobs for Temporal, LiteLLM, and Traefik services.
Update Prometheus config to separate and clarify scrape targets.
Document new scrape targets in monitoring README.
Changes walkthrough 📝
prometheus.yml
Add and organize Prometheus scrape jobs for new services
monitoring/prometheus/config/prometheus.yml
README.md
Document new Prometheus scrape targets in README
monitoring/README.md
Important
Add Prometheus scrape jobs for Temporal, LiteLLM, and Traefik, and update documentation.
temporal
scrape job inprometheus.yml
fortemporal:15000
andtemporal-managed:15000
.litellm
scrape job inprometheus.yml
forlitellm:4000
andlitellm-managed:4000
.traefik
scrape job inprometheus.yml
forgateway:8082
.README.md
to include new scrape targets: Temporal, LiteLLM, and Traefik.This description was created by
for 2b77843. You can customize this summary. It will automatically update as commits are pushed.