Skip to content

require that $schema cannot contain a fragment #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

require that $schema cannot contain a fragment #1633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specs/jsonschema-core.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,8 +957,8 @@ resources, unless such a resource itself declares a different dialect by
including the `$schema` keyword with a different value.

The value of this keyword MUST be an
[IRI](https://www.rfc-editor.org/info/rfc3987) (containing a scheme) and this
IRI MUST be normalized.
[IRI](https://www.rfc-editor.org/info/rfc3987) (containing a scheme). This
IRI MUST be normalized and MUST NOT contain a fragment.
Comment on lines +960 to +961
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be called an "absolute IRI" instead of just an "IRI". Then we don't have to make a normative statement that a fragment isn't allowed because that's part of the definition of "absolute IRI". However, it might be a good idea to clarify that fact since most people think "absolute" just means "non-relative". Which means we shouldn't need to clarify that it mean "containing a scheme" anymore. Maybe something like this would work,

Suggested change
[IRI](https://www.rfc-editor.org/info/rfc3987) (containing a scheme). This
IRI MUST be normalized and MUST NOT contain a fragment.
[absolute IRI](https://www.rfc-editor.org/info/rfc3987) (without a fragment). This
IRI MUST be normalized.


If this IRI identifies a retrievable resource, that resource SHOULD be of media
type `application/schema+json`.
Expand Down
Loading