Skip to content

fix: remove various repo files that leaked into the sdist of the package #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenstroeger
Copy link
Owner

@jenstroeger jenstroeger commented Jun 2, 2025

@behnazh the sdist still contains the pyproject.toml file:

> tar tvf dist/package-2.16.0.tar.gz 
-rw-r--r-- 0/0            1063 2025-06-03 00:17 package-2.16.0/LICENSE.md
-rw-r--r-- 0/0           28836 2025-06-03 00:17 package-2.16.0/README.md
-rw-r--r-- 0/0            8257 2025-06-03 00:17 package-2.16.0/pyproject.toml
-rw-r--r-- 0/0             386 2025-06-03 00:17 package-2.16.0/src/package/__init__.py
-rw-r--r-- 0/0             496 2025-06-03 00:17 package-2.16.0/src/package/__main__.py
-rw-r--r-- 0/0              80 2025-06-03 00:17 package-2.16.0/src/package/py.typed
-rw-r--r-- 0/0             520 2025-06-03 00:17 package-2.16.0/src/package/something.py
-rw-r--r-- 0/0            1352 1970-01-01 10:00 package-2.16.0/setup.py
-rw-r--r-- 0/0           31320 1970-01-01 10:00 package-2.16.0/PKG-INFO

which contains all development dependencies masquerading as package extras:

actions = [
"commitizen ==4.5.0",
"twine ==6.1.0",
]
dev = [
"flit >=3.2.0,<4.0.0",
"mypy >=1.0.0,<1.15",
"pip-audit >=2.4.4,<3.0.0",
"pylint >=3.0.0,<3.4.0",
"perflint >=0.8.0,<1.0.0",
"cyclonedx-bom >=4.0.0,<5.0.0",
]
docs = [
"sphinx >=5.1.1,<9.0.0",
"sphinx-markdown-builder >=0.6.4,<1.0.0",
]
hooks = [
"pre-commit >=3.0.0,<4.1.0",
]
# Note that the `custom_exit_code` and `env` plugins may currently be unmaintained.
test = [
"faker ==37.1.0",
"hypothesis >=6.21.0,<6.130.9",
"pytest >=7.2.0,<9.0.0",
"pytest-cases ==3.8.6",
"pytest-custom_exit_code ==0.3.0",
"pytest-cov ==6.1.0",
"pytest-doctestplus ==1.3.0",
"pytest-env ==1.1.5",
]
as well as all settings for many of the development tools which are completely unrelated to the package’s sdist itself.

See issue #951.

@jenstroeger jenstroeger requested a review from behnazh as a code owner June 2, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants