Update iso_c_binding usage #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your efforts. I’ll test it in the next days and get back to you. |
|
WTF?! None of tests were passed... |
|
Why did you merge? |
|
Sorry, I was just lazy. I’ve refactored it and then tested with gfortran 14, gfortran 15, and flang 20. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, I've replaced almost all
iso_c_bindingwithsdl2_c_typesmodule that provides all necessary types. Now, they are used withonly(checked with-Wuse-without-only).In many modules, I've add default private visibility of those modules' entities.
src/c_util.F90was moved tosrc/sdl2/sdl2_c_types.F90. Now, it can enable unsigned support once one provide-DHAS_UNSIGNEDflag. It should help to work with-funsignedflags for Flang and GCC.Note: I did not tests examples. All changes were made in
-fsyntax-onlymode since I do not have SDL2