refactor: unset $RUSTC_WRAPPER so it doesn't add an extra rustc arg
#1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/refactor-extra-rustc-arg
branch
from
dd72341 to
3ac7ccc
Compare
Contributor
|
Out of curiosity, in which situations is |
kkysen
commented
Dec 11, 2025
Contributor
Author
There was a problem hiding this comment.
Out of curiosity, in which situations is
RUSTC_WRAPPERset?
It's set by tools like sccache, but also c2rust-analyze and c2rust-instrument so that they can intercept rustc invocations through cargo. I think tools like clippy work this way, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
$RUSTC_WRAPPERis set,rustcinvocations will be add an extra"rustc"arg, which trips up the arg parsing code with an unexpected arg.