Audio encodings now match conv2d weight dtype in Gemma3nAudioSSCPConvBlock #39743
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The change ensures that the audio encodings are cast to the same type as
conv.weight
tensor. This is done by appendingto(self.conv.weight.dtype)
to theaudio_encodings_padded
rvalue.Fixes an issue where the conv2d forward pass throws an error. Code for reproducible error (run on Mac M1) :
Full stack trace is attached error.txt.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Suggested Reviewers
@ArthurZucker