feat: add animation support to Dropdown component #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoketV
approved these changes
Dec 24, 2024
|
Any update on this? |
|
Hi! I’ve the same needs. Could we resolve all conflicts on this branch and proceed with a merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use react native animated api to animate the height of the view inside the dropdown modal so that it opens and closes more fluently.
adds new prop - animationDuration which defaults to 300ms. setting this to 0ms will make the dropdown open and close instantly, increasing the duration makes it open and close more slowly.
this was requested in issue #287