修改Grid.cpp的部分逻辑和代码优化 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
初始化列表：在构造函数中使用初始化列表来初始化成员变量。
代码风格：保持代码风格的一致性，例如大括号的使用和缩进。
内存管理：ROWSPAN row(10); 这一行看起来像是在创建一个具有10个元素的行，但是没有初始化这些元素。如果 ROWSPAN 是 std::vector，那么应该初始化所有元素为0。
代码逻辑：lineStatus 函数的逻辑有点问题，它应该检查一行是否完全被填满，但是当前的实现并不清晰。
代码注释：添加更多的注释来解释代码的功能和逻辑。