Skip to content

fix: correct ECDSA signature format and transaction signing logic #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: correct ECDSA signature format and transaction signing logic #223

wants to merge 3 commits into from
+38 −10

Conversation

0xJohnZW
Copy link

Description:

  • Fix ECDSA signing to use keccak256 hash and convert DER signature to raw 64-byte format
  • Fix transaction signing to use appropriate signature field based on key type (ed25519 vs ECDSA_secp256k1)

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

0xJohnZW added 2 commits July 31, 2025 19:59
@0xJohnZW
- Fix ECDSA signing to use keccak256 hash and convert DER signature t…
f17d6f5 
…o raw 64-byte format

- Fix transaction signing to use appropriate signature field based on key type (ed25519 vs ECDSA_secp256k1)

Signed-off-by: 0xJohnZW <roseiliend@gmail.com>
@0xJohnZW
Update ECDSA signature verification to match signing format changes
6fb62fe 
Signed-off-by: 0xJohnZW <roseiliend@gmail.com>
@0xJohnZW 0xJohnZW mentioned this pull request Jul 31, 2025
Closed
2 tasks
@0xJohnZW
fix test_verify_ecdsa_success
7c0f215 
Signed-off-by: 0xJohnZW <roseiliend@gmail.com>
@0xJohnZW 0xJohnZW force-pushed the fix/ecdsa-signature-format-v2 branch from ed9d66c to 7c0f215 Compare July 31, 2025 14:44
exploreriii
exploreriii approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@0xJohnZW
Copy link
Author

0xJohnZW commented Aug 1, 2025

hi, @exploreriii , the StepSecurity Harden-Runner check failed, but I lack the permissions to access the details. What else do I need to do here?

@nadineloepfe
Copy link
Contributor

nadineloepfe commented Aug 1, 2025 •
edited
Loading

@0xJohnZW: the error seems to be coming from our own solo-actions package, which is weird. let's rerun and hope that fixes it. then it can be merged. thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exploreriii exploreriii exploreriii approved these changes

@nadineloepfe nadineloepfe nadineloepfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xJohnZW @nadineloepfe @exploreriii