feat: Added TokenCancelAirdropTransaction
#208
+1,069
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
manishdait
force-pushed
the
feat/cancel_airdrop
branch
from
2d4210a to
ed96ae5
Compare
| self.pending_airdrop_id = pending_airdrop_id | ||
| self.amount = amount | ||
|
|
||
| def get_pending_airdrop_id(self) -> "PendingAirdropId": |
There was a problem hiding this comment.
bit of a Java-ism. In Python, it's more idiomatic to access public properties directly (eg record.pending_airdrop_id). so we could consider removing this to make the class feel more "conventionally pythonic"
| super().__init__() | ||
| self.pending_airdrops: list[PendingAirdropId] = [] | ||
| if (pending_airdrops is not None): | ||
| self.set_pending_airdrops(pending_airdrops) |
There was a problem hiding this comment.
Suggested change
| self.set_pending_airdrops(pending_airdrops) | |
| self.pending_airdrops = pending_airdrops or [] |
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
manishdait
force-pushed
the
feat/cancel_airdrop
branch
from
877c44b to
ed521d4
Compare
|
Hello manish how is this progressing, is it ready for review? |
I think it's ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implemented the
TokenCancelAirdropTransactionclass to cancel one or more airdrops on network.Changes:
PendingAirdropIdandPendingAirdropRecordclass to unique identifier a pending airdrop and store their dataPendingAirdropIdandPendingAirdropRecordTransactionRecordwithnew_pending_airdropsfield to lists the pending airdrops that were created or updated during token_airdrop_txTransactionRecordTokenCancelAirdropTransactionclass ImplementationTokenCancelAirdropTransactionREADME.mdin examples folder__init__.pyfile with new class definition in__all__listRelated issue(s):
Fixes #202
Checklist