Skip to content

feat: add ContractCreateTransaction #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Aug 3, 2025
Merged

feat: add ContractCreateTransaction #198

merged 32 commits into from
Aug 3, 2025
+3,997 −1

Conversation

Dosik13
Copy link
Contributor

@Dosik13 Dosik13 commented Jul 18, 2025 •
edited
Loading

Description:
Implemented the ContractCreateTransaction class that allows creating smart contracts on the network.

  • Add ContractId class for contract identifier representation
  • Add unit tests for ContractId class
  • Add ContractFunctionParameters class for contract function parameter handling using https://github.com/ethereum/eth-abi/tree/main
  • Add eth-abi dependency in pyproject.toml
  • Add comprehensive type stub file (contract_function_parameters.pyi) for enhanced IDE support and type checking
  • Add ContractCreateTransaction class implementation
  • Add unit tests for ContractCreateTransaction class
  • Add integration tests for ContractCreateTransaction
  • Export contract_id property in TransactionReceipt class
  • Update examples README with contract create transaction documentation
  • Add contract create transaction examples
    • contract create with simple contract
    • contract create with stateful contract (using contract constructor)
    • contract create directly with bytecode (without using file)

Related issue(s):

Fixes #197

Notes for reviewer:

The purpose of the ContractFunctionParameters class is to encode parameters for smart contract function calls using the Ethereum ABI format. It uses eth-abi library to handle the low-level encoding details while providing a clean, fluent API.

The class employs dynamic method generation to create methods for all integer types (int8-int256, uint8-uint256) at runtime, avoiding repetitive code. This approach is complemented by a comprehensive type stub file (.pyi) that provides IDE support and static type checking.

Also, I added eth-abi dependency in pyproject.toml so every dependency is installed properly.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

exploreriii
exploreriii reviewed Jul 19, 2025
View reviewed changes
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool

@Dosik13 Dosik13 force-pushed the feature/add-ContractCreateTransaction branch 2 times, most recently from 62d6399 to 99202bf Compare July 21, 2025 12:58
@Dosik13 Dosik13 marked this pull request as ready for review July 28, 2025 13:05
@Dosik13 Dosik13 force-pushed the feature/add-ContractCreateTransaction branch from 747f3db to 2179030 Compare July 28, 2025 21:50
@Dosik13 Dosik13 requested a review from exploreriii July 30, 2025 08:33
exploreriii

This comment was marked as resolved.

Sign in to view

@Dosik13 Dosik13 enabled auto-merge (squash) July 31, 2025 06:10
exploreriii
exploreriii reviewed Jul 31, 2025
View reviewed changes
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me looks good, am not sure on the source of the check error at the moment

@nadineloepfe
Copy link
Contributor

the error seems to be coming from our own solo-actions package, which is weird. let's rerun and hope that fixes it

@exploreriii
Copy link
Contributor

Hi @Dosik13 could you try pushing an empty commit and see if that will re-trigger the runner check, which should pass this time

Dosik13 added 15 commits August 3, 2025 21:52
@Dosik13
feat: add ContractSelector class
b9da071 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
feat: add ContractFunctionParamters
0c71444 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
feat: add ContractId class
e9336cb 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
test: add unit tests for contractId
8347e4b 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
feat: export contract_id in transaction_receipt
ed66460 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
feat: add ContractCreateTransaction class
176018f 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
test: add unit tests for ContractCreateTransaction
0c37662 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
test: add integration tests forContractCreateTransaction
76d1bfa 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
docs: add ContractCreateTransaction in examples README
f995fac 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
docs: add contract create example
6a9fda6 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
feat: add contract bytecode files (SimpleContract for basic testing, …
2f01c48 
…StatefulContract for state management)

Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
feat: add contract bytecode loader utility and examples module initia…
14574b7 
…lization

Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
test: update ContractCreate integration tests to use contract utils a…
bc6abbc 
…nd add constructor test

Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
chore: fix linting issues in contract utilities
cbb5e89 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
docs: update contract create example
0762866 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
Dosik13 added 17 commits August 3, 2025 21:53
@Dosik13
docs: add contract create with constructor example
a94c714 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
chore: address PR feedback for contract create
49d6d09 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
refactor: migrate ContractFunctionParameters to use eth-abi for param…
2857dc7 
…eter encoding

Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
feat: add type stub file for ContractFunctionParameters with eth-abi …
02ae3f3 
…support

Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
docs: update examples
b8a17c6 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
docs: add contract creation example with direct bytecode usage
ad13d2b 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
chore: address PR feedback
f893875 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
fix: remove unnecessary added add_function() method from ContractFunc…
ea5a44a 
…tionParameters

Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
feat: add ConstructorTestContract smart contract for testing Contract…
a0c55a2 
…FunctionParameters

Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
test: add integration tests for ContracFunctionParameters
4673816 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
chore: add ContractCreateTransaction and ContractFunctionParameters t…
2f957f1 
…o __init__.py

Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
feat: add eth-abi dependency for contract parameter encoding
11ae8a6 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
fix: update ConstructorTestContract bytecode to match compiled version
19b212b 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
docs: add parameter order comments in contract test
acd1198 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
docs: add more documentaton in contract utils
010308c 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
chore: address PR feedback
c3c581e 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13
chore: address incorrect error raising
ee4b724 
Signed-off-by: dosi <dosi.kolev@limechain.tech>
@Dosik13 Dosik13 force-pushed the feature/add-ContractCreateTransaction branch from 76236d3 to ee4b724 Compare August 3, 2025 18:53
exploreriii
exploreriii approved these changes Aug 3, 2025
View reviewed changes
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Dosik13 Dosik13 merged commit 8da0e6c into hiero-ledger:main Aug 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exploreriii exploreriii exploreriii approved these changes

@nadineloepfe nadineloepfe Awaiting requested review from nadineloepfe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ContractCreateTransaction
3 participants
@Dosik13 @nadineloepfe @exploreriii