fix: Fix signer nonce translation for batch ethCalls #20315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20315 +/- ##
=========================================
Coverage 71.22% 71.22%
- Complexity 24136 24137 +1
=========================================
Files 2652 2652
Lines 102279 102279
Branches 10629 10629
=========================================
+ Hits 72851 72853 +2
+ Misses 25454 25452 -2
Partials 3974 3974 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
vtronkov
reviewed
Jul 24, 2025
.../java/com/hedera/services/bdd/suites/contract/leaky/batch/AtomicLeakyContractTestsSuite.java
Show resolved
Hide resolved
vtronkov
previously approved these changes
Jul 24, 2025
timfn-hg
reviewed
Jul 25, 2025
| @@ -984,4 +981,24 @@ private boolean allMintsAreFound() { | |||
| } | |||
| return true; | |||
| } | |||
|
|
|||
| public boolean isNonceIncremented( | |||
There was a problem hiding this comment.
Can we add some JavaDoc or at least nullability annotations?. Additionally, this is prone to throwing a NullPointerException if nonce is null because of currentNonce > nonce.
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
JivkoKelchev
previously approved these changes
Jul 30, 2025
| @@ -984,4 +981,24 @@ private boolean allMintsAreFound() { | |||
| } | |||
| return true; | |||
| } | |||
|
|
|||
| public boolean isNonceIncremented( | |||
# Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/junit/support/translators/BaseTranslator.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/junit/support/translators/impl/EthereumTransactionTranslator.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/contract/records/batch/AtomicRecordsSuite.java
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add specific translation login in
EthereumTransactionTranslatorfor inner batch transactions that populates thesignerNoncefrom the inputDataRelated issue(s):
Fixes #
#20344
Notes for reviewer:
Checklist