-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19388 Process <database-object> in mapping.xml #10998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
metadataSources.addInputStream( getClass().getResourceAsStream( "no-file-level-catalog-and-schema.hbm.xml" ) ); | ||
metadataSources.addInputStream( getClass().getResourceAsStream( "database-object-using-catalog-placeholder.hbm.xml" ) ); | ||
metadataSources.addInputStream( getClass().getResourceAsStream( "database-object-using-schema-placeholder.hbm.xml" ) ); | ||
metadataSources.addInputStream( getClass().getResourceAsStream( "database-object-using-catalog-placeholder.orm.xml" ) ); |
Check warning
Code scanning / CodeQL
Unsafe use of getResource Warning test
metadataSources.addInputStream( getClass().getResourceAsStream( "database-object-using-catalog-placeholder.hbm.xml" ) ); | ||
metadataSources.addInputStream( getClass().getResourceAsStream( "database-object-using-schema-placeholder.hbm.xml" ) ); | ||
metadataSources.addInputStream( getClass().getResourceAsStream( "database-object-using-catalog-placeholder.orm.xml" ) ); | ||
metadataSources.addInputStream( getClass().getResourceAsStream( "database-object-using-schema-placeholder.orm.xml" ) ); |
Check warning
Code scanning / CodeQL
Unsafe use of getResource Warning test
|
||
context.getMetadataCollector().getDatabase().addAuxiliaryDatabaseObject( auxDbObject ); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move this to a dedicated binder related to mapping.xml. Ultimately we will drop hbm.xml processing and woould be better at that point to not have to sift through hbm.xm-processing code to pull out bits related to mapping.xml. Does that make sense?
context.getBootstrapContext().getClassLoaderService() | ||
.classForName( databaseObjectRegistration.definition() ) | ||
.newInstance(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
https://hibernate.atlassian.net/browse/HHH-19388
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.