-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Added socket listening #13896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shitohana
wants to merge
10
commits into
helix-editor:master
Choose a base branch
from
shitohana:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added socket listening #13896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now socket is created with mode 'o600' Socket path is configurable with env variable HELIX_SOCKET_PATH
I think this should use |
Added XDG_RUNTIME_DIR as the first environment variable to lookup on no HELIX_SOCKET_PATH. If XDG_RUNTIME_DIR is not set falling back to /tmp. Added checking, if parent of HELIX_SOCKET_PATH exists or error otherwise. If using XDG_RUNTIME_DIR or /tmp, `helix` folder is created there. For security reasons added list of forbidden commands, which can be used to inject unwanted data into editor or execute shell command. I suppose, macros validation should also be added. Currently forbidden commands are write* and run-shell-command. If forbidden command is received - error message is shown.
idealseal
reviewed
Jul 8, 2025
329715d
to
1a18170
Compare
…ditor#13909) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements Unix socket support for the Helix editor, addressing #387. It enables external processes to send commands to a running Helix instance via a Unix socket, improving automation and integration capabilities. Since a plugin system is not planned for near-term addition, this feature provides a practical way to communicate with Helix from other processes (e.g., opening files from tools like Yazi or Broot).
Changes
Why Merge
Potential Improvements
Diff Summary