Decouple the session loader into reader and writer over the cache #4445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them to improve performance fix haskell#4381
…p error loading and cradle files
soulomoon
force-pushed
the
batch-load-multi-read
branch
from
ba7379b to
79a43a0
Compare
Renames getOptions to getOptionsWorker for clarity Removes redundant getOptionsLoop function Ensures session loading is called under the same `Action` context
…ration of concerns
The session initialisation has too many implicit dependencies. To break these apart, we extract local functions and turn them into top-level definition with all parameters explicitly given. This commit only makes sure session initialisation functions are promoted to top-level definitions and tries to simplify them. The top-level definitions are lacking type signatures to make it easier to change them, but we plan to add them back.
fendor
reviewed
Aug 4, 2025
| import StmContainers.Set (Set) | ||
|
|
||
|
|
||
| type OrderedSet a = (TQueue a, Set a) |
There was a problem hiding this comment.
Lets make this a proper datatype, e.g.
data TOrderedSet = TOrderedSet
{ insertionOrder :: TQueue a
, elements :: Set a
}at the very least, this should be a newtype.
Comment on lines
+16
to
+17
| insert :: Hashable a => a -> OrderedSet a -> STM () | ||
| insert a (que, s) = do |
There was a problem hiding this comment.
Docs please!
The behaviour feels non-standard and non-trivial.
Expected complexity is also appreciated.
| s <- S.newIO | ||
| return (que, s) | ||
|
|
||
| readQueue :: Hashable a => OrderedSet a -> STM a |
There was a problem hiding this comment.
Docs please, what is the purpose and behaviour?
Comment on lines
+44
to
+45
| delete :: Hashable a => a -> OrderedSet a -> STM () | ||
| delete a (_, s) = S.delete a s |
There was a problem hiding this comment.
Docs please explaining why we don't have to delete the element from the TQueue as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of and already include the changes in #4439
Refactored session loader to use architecture that having multiple readers and writer over the cache .
In bigger project, HLS usually loading up slow. One of the main obstacle is that we are loading ghc options for files in strict sequential order.
I have made an attemp to improve the situation by refactoring this loading into reader and writer over cache. This way, the long laoding file won't be blocking already loaded files, making hls more responsive and smooth.
Also it eliminates session loading for the same file from being multiply requested, by lining up in an ordered set in stead of a list.