fix: display values for Y-axis when data points are all identical #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
When all data points in a series have identical values (e.g.,
[1, 1, 1, 1, 1]
), the Y-axis would not display the correct value labels. This occurred because when the interval between minimum and maximum values is zero, the calculation for Y-axis labels would fail to produce meaningful output.Issues
resolves #61
Root Cause
The issue was in the Y-axis label calculation logic in
asciigraph.go
. Wheninterval = 0
(all data points are identical), the code would setratio = 1
but the subsequent calculations forrows
and Y-axis label positioning would not handle this edge case properly, resulting in missing or incorrect Y-axis values.Fix Details
The fix ensures that when all data points are identical:
Impact
I already asked about solving this in #61 comments~
If have any concerns, pls comment below! I'll reply ASAP.