Skip to content

Fixes #4200. ExtendedCharInfo needs be enhanced to properly deal with all codepoints #4202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: v2_develop
Choose a base branch
from
Open

Fixes #4200. ExtendedCharInfo needs be enhanced to properly deal with all codepoints #4202

wants to merge 26 commits into from

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jul 22, 2025 •
edited
Loading

Fixes

Proposed Changes/Todos

  • Add support for surrogate pairs in WindowsOutput and WindowsDriver
  • Also supports 16 Colors with a supported font

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

BDisp added 12 commits July 21, 2025 16:53
@BDisp
Fixes gui-cs#4196. Application.Begin doesn't refresh the screen at start
2d1ab6f
@BDisp
Fixes gui-cs#4198. Application.Invoke isn't wakeup the driver if idle
a470275
@BDisp
Reformatting to run CI again
ef639c1
@BDisp
Revert "Reformatting to run CI again"
d2acdf6 
This reverts commit ef639c1.
@BDisp
Trying fix an issue where sometimes subview variable is null running …
e48466f 
…unit tests
@BDisp
Merge branch 'v2_4198_application-invoke-wakeup-fix' into v2_4200_wid…
0a52c49 
…er-surrogatepair-force16colors-fix
@BDisp
Replace ExtendedCharInfo.Char with char array
fea1d4f
@BDisp
Replace IsWindowsTerminal with IsVirtualTerminal
7097c0b
@BDisp
Add a lastSize parameter to process resize automatically
8ef7116
@BDisp
Handling surrogate pairs in input
1a2fb66
@BDisp
Implement SetConsoleTextAttribute
9c25a7c
@BDisp
Prevent select true color is not supported
69e1986
@BDisp BDisp requested a review from tig as a code owner July 22, 2025 16:55
@BDisp BDisp marked this pull request as draft July 22, 2025 16:55
tznind
tznind reviewed Jul 22, 2025
View reviewed changes
Terminal.Gui/Drivers/V2/WindowSizeMonitor.cs Outdated

if (_consoleOut.GetType().Name == "WindowsOutput")
{
newSize = _consoleOut.SetWindowSize (size);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resizing code looks confusing... can you explain why it is necessary to detect change in size and immediately order the output to resize itself again?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When windows is resized the buffer isn't correctly resized. So the code force resize the buffer correctly and thus there is no scroll buffer.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid this.

devenv_ubd46dG3Un

Copy link
Collaborator Author

@BDisp BDisp Jul 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I recognize that isn't good as is. So, feel free to change all you want.

@tznind tznind mentioned this pull request Jul 23, 2025
Open
@BDisp BDisp marked this pull request as ready for review July 31, 2025 00:25
@BDisp BDisp mentioned this pull request Jul 31, 2025
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tznind tznind tznind left review comments

@tig tig Awaiting requested review from tig tig is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Legacy consoles width shrink on restore after maximize ExtendedCharInfo needs be enhanced to properly deal with all codepoints
2 participants
@BDisp @tznind