Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Update BrowserVersionDetector.java #434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update BrowserVersionDetector.java #434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...idExtras/src/main/java/com/groupon/seleniumgridextras/browser/BrowserVersionDetector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ public static String guessBrowserVersion(String browserName) {
return getIEVersion();
} else if (browserName.equalsIgnoreCase("internet explorer")) {
return getIEVersion();
} else if (browserName.equalsIgnoreCase("safari")) {
return getSafariVersion();
} else {
return "";
}
Expand Down Expand Up @@ -236,4 +238,22 @@ private static String getChromeVersion() {
}
return version;
}

/**
*
* @return version of Safari installed
*/
private static String getSafariVersion() {
String version ="";
try {
String cmd = "mdls -name kMDItemVersion /Applications/Safari.app";
JsonObject object = ExecuteCommand.execRuntime(cmd, true);
logger.info("Detected Safari version: " + object.get("out").getAsJsonArray().get(0).getAsString().trim().replaceAll("[^\\d.]", ""));
version = object.get("out").getAsJsonArray().get(0).getAsString().trim().replaceAll("[^\\d.]", "");
} catch (Exception e) {
// If ExecuteCommand.execRuntime fails, still return "";
logger.warn(e.getMessage());
}
return version;
}
}