This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Working branch #425
Open
Working branch #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadly, no one answered on my issue groupon#391. Because i need InternetExplorer working, i now propose this code change (that is only necessary because the broken folder exists). If this broken folder is deleted, this code change would not be necessary.
followed the great suggestion of @smccarthy
repair issue 391 but from code side
Fix for Firefox version detection on 64 bit Windows
|
I am working on getting a mac to test why the build is failing. Everything works fine on my windows machine and all tests pass. If anyone has ideas how I can test this further please let me know. |
|
Any idea why the CI build is failing? |
|
I think it has to do with TravisCI running tests that download drivers and it's blocking those tests from performing the actions. I tried debugging but could only get so far. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to allow this branch to run the latest version of Selenium.