Skip to content

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Sep 26, 2025

The desktop.recording audit event is the analogous to the session "print" event - it is emitted to session recordings but not to the audit log, and contains the recorded session data.

The event handler was configured to skip SSH/Kube recording events by default, but not desktop events. Desktop recording events are even less useful for forwarding since they are mostly binary data.

Changelog: The event-handler plugin will now skip over Windows desktop session recording events by default.

The desktop.recording audit event is the analogous to the session
"print" event - it is emitted to session recordings but not to
the audit log, and contains the recorded session data.

The event handler was configured to skip SSH/Kube recording events
by default, but not desktop events. Desktop recording events are
even less useful for forwarding since they are mostly binary data.
Copy link

github-actions bot commented Sep 26, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
zmb3/event-handler-skip-desktop HEAD 1 ✅SUCCEED zmb3-event-handler-skip-desktop 2025-09-26 15:14:02

Copy link
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is somewhat breaking and we won't backport it and add a note in v19 changelog?

@zmb3
Copy link
Collaborator Author

zmb3 commented Sep 26, 2025

I suppose this is somewhat breaking and we won't backport it and add a note in v19 changelog?

I'm not sure, I don't have much experience w/ event handler, but maybe a backport wouldn't be a bad thing.. There's lots of desktop recording events and they are large since they contain encoded screen fragments. Pretty useless to have in a SIEM I would think.

@tigrato
Copy link
Contributor

tigrato commented Sep 26, 2025

I suppose this is somewhat breaking and we won't backport it and add a note in v19 changelog?

I'm not sure, I don't have much experience w/ event handler, but maybe a backport wouldn't be a bad thing.. There's lots of desktop recording events and they are large since they contain encoded screen fragments. Pretty useless to have in a SIEM I would think.

I also think that backporting is not that bad here.

@zmb3
Copy link
Collaborator Author

zmb3 commented Sep 26, 2025

I also think that backporting is not that here.

Sorry, to clarify is that a vote for backporting or against backporting?

@tigrato
Copy link
Contributor

tigrato commented Sep 26, 2025

I also think that backporting is not that here.

Sorry, to clarify is that a vote for backporting or against backporting?

it's a vote for backporting. I missed a word

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants