-
Notifications
You must be signed in to change notification settings - Fork 1.9k
event-hander: skip desktop recording events by default #59651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The desktop.recording audit event is the analogous to the session "print" event - it is emitted to session recordings but not to the audit log, and contains the recorded session data. The event handler was configured to skip SSH/Kube recording events by default, but not desktop events. Desktop recording events are even less useful for forwarding since they are mostly binary data.
Amplify deployment status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this is somewhat breaking and we won't backport it and add a note in v19 changelog?
I'm not sure, I don't have much experience w/ event handler, but maybe a backport wouldn't be a bad thing.. There's lots of desktop recording events and they are large since they contain encoded screen fragments. Pretty useless to have in a SIEM I would think. |
I also think that backporting is not that bad here. |
Sorry, to clarify is that a vote for backporting or against backporting? |
it's a vote for backporting. I missed a word |
The desktop.recording audit event is the analogous to the session "print" event - it is emitted to session recordings but not to the audit log, and contains the recorded session data.
The event handler was configured to skip SSH/Kube recording events by default, but not desktop events. Desktop recording events are even less useful for forwarding since they are mostly binary data.
Changelog: The event-handler plugin will now skip over Windows desktop session recording events by default.