Adjust items
type for IncrementalStreamResult
and FormattedIncrementalStreamResult
#4483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the following:
When providing a generic to
*IncrementalResult
, theitems
property on*IncrementalStreamResult
is typed incorrect due to theArray<*>
being part of the default type instead of theitems
property. This means calling array methods onitems
results in a TypeScript error since TypeScript doesn't know its an array. This is incorrect sinceitems
can only be an array type and nothing else. Here is the reproduction in TS Playground.This PR fixes this issue by moving the
Array<*>
wrapper to theitems
type so that this works as expected.