chore: include rule id in pyroscope_metrics_exporter_series_sent_total #4454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
reviewed
Sep 25, 2025
| seriesByRuleID[ruleID]++ | ||
| } | ||
| for ruleID, count := range seriesByRuleID { | ||
| e.metrics.seriesSent.WithLabelValues(tenantId, ruleID).Add(float64(count)) |
There was a problem hiding this comment.
Can you estimate the extra cardinality that this will add?
There was a problem hiding this comment.
Cardinality could be described as "total number of tenants using recording rules times the number of instances of compaction workers in that cell". After the change, we would describe as "total number of rules defined by all the tenants times the number of instances of compaction workers in that cell".
So it's safe to talk about a x10-x50 increase in cardinality. In the case of ops we would go from 32 to 320 series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to easily find rules that contribute the most to an eventual alert on tenants hitting cardinality limits.
We can make this more efficient in a previous layer of the code, but I avoided changing interfaces too much, while this code runs in a separate thread I think we can deal with it