fix: Correctly determine project ID for metrics export #2427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
surbhigarg92
force-pushed
the
metrics_projectId
branch
from
3fd589f to
dd60592
Compare
surbhigarg92
changed the title
surbhigarg92
force-pushed
the
metrics_projectId
branch
from
dd60592 to
91f9bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2420
This PR addresses an issue where the project ID for metrics export was not being correctly determined when not explicitly provided.
Specifically, this PR introduces the following changes:
Infers Project ID from Credentials: When a Spanner instance is created without a projectId in the spanner options, the project ID is now fetched from the authentication credentials. This ensures that metrics are correctly exported to the appropriate project, resolving an issue where a placeholder {{project_id}} was being used.
This PR also makes the
projectIdattribute to be non-optional inMetricsTracerFactory.getInstancemethod