-
Notifications
You must be signed in to change notification settings - Fork 418
samples(storage): Add region tags in fastbyte samples #15403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15403 +/- ##
==========================================
- Coverage 93.03% 93.03% -0.01%
==========================================
Files 2403 2403
Lines 219441 219441
==========================================
- Hits 204148 204147 -1
- Misses 15293 15294 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
co_return (co_await std::move(c1)) + (co_await std::move(c2)); | ||
}; | ||
//! [open-object-multiple-ranged-read] | ||
// [END storage_read_appendable_object_mulitple_ranges] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: use multiple
in region tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR title should be samples(storage) or chore(storage)
Please make sure to merge it with conventional commit |
Added region tags for fastbyte samples
This change is