Skip to content

Conversation

v-pratap
Copy link
Contributor

@v-pratap v-pratap commented Aug 25, 2025

Added region tags for fastbyte samples


This change is Reviewable

@v-pratap v-pratap requested review from a team as code owners August 25, 2025 09:30
@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Aug 25, 2025
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.03%. Comparing base (b4bf27b) to head (51a9acd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15403      +/-   ##
==========================================
- Coverage   93.03%   93.03%   -0.01%     
==========================================
  Files        2403     2403              
  Lines      219441   219441              
==========================================
- Hits       204148   204147       -1     
- Misses      15293    15294       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

co_return (co_await std::move(c1)) + (co_await std::move(c2));
};
//! [open-object-multiple-ranged-read]
// [END storage_read_appendable_object_mulitple_ranges]
Copy link
Member

@Pulkit0110 Pulkit0110 Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: use multiple in region tag

Copy link
Member

@Pulkit0110 Pulkit0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR title should be samples(storage) or chore(storage)

@bajajneha27 bajajneha27 changed the title feat(storage): Add region tags in fastbyte samples samples(storage): Add region tags in fastbyte samples Sep 23, 2025
@bajajneha27
Copy link
Contributor

Please make sure to merge it with conventional commit samples instead of feat. We don't want this in our changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants