feat: don't require crc32c with recent Abseil #15402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc2a564 (googleapis#11061) introduced Abseil based CRC32C implementation. So we don't require crc32c when we use recent Abseil. If we don't require crc32c with recent Abseil, downstream users such as Apache Arrow don't need to bundle crc32c. It reduces maintenance cost. See also: apache/arrow#45989
kou
commented
Aug 25, 2025
| CURL::libcurl | ||
| Threads::Threads) | ||
| if (NEED_CRC32C) | ||
| target_link_libraries(google_cloud_cpp_storage PUBLIC Crc32c::crc32c) |
There was a problem hiding this comment.
I think that we can use PRIVATE here because crc32c/crc32c.h isn't used in public headers.
But I keep using PUBLIC in this PR.
|
|
||
| set(PKGCONFIG_LIBS) | ||
| if (NEED_CRC32C) | ||
| list(APPEND PKGCONFIG_LIBS crc32c) |
There was a problem hiding this comment.
I think that we don't need to add crc32c to .pc because it's not used in public headers.
But I keep adding crc32c to .pc in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc2a564 (#11061) introduced Abseil based CRC32C implementation. So we don't require crc32c when we use recent Abseil.
If we don't require crc32c with recent Abseil, downstream users such as Apache Arrow don't need to bundle crc32c. It reduces maintenance cost.
See also: apache/arrow#45989
This change is