"Token Types" chapter of Idiomatic Rust #2921
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The previous STYLE.md advised against using speaker notes as a 'script' but didn't provide clear examples of what that meant. This could be interpreted by LLMs as disallowing any kind of instructor prompt. This change clarifies the guideline by: 1. Distinguishing between long-form, verbatim 'scripts' (bad) and short, actionable 'teaching prompts' (good). 2. Providing concrete 'good' and 'bad' examples to make the distinction unambiguous for future contributors.
| println!("Could not get token."); | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Sorry to be annoying, but the code block here looks way too long. We typically don't have room for 25 lines of code in a classroom setting.
There was a problem hiding this comment.
@djmitche and @gribozavr, I would like to see the red box CSS trick be resurrected so that it's easier to know when a slide becomes too big to fit.
@michael-kerscher, would it be feasible to flag new slides automatically with the CI code you wrote?
There was a problem hiding this comment.
Not annoying at all! I'm still picking up practical instruction details in feedback cycles, though right now structure and content feedback is greatly appreciated 🙂
…all-vase/comprehensive-rust into idiomatic/typesystem-tokens
Materials on "token types."
The "Branded tokens" section of this one requires a little extra scrutiny. It may be the case it is too complex for this stage, or that the explanation isn't suitable for the audience/instructors. Either way, I'm eager for input.