Skip to content

cmd/link: remove hard dependency on ld.gold on aarch64 #75074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −20
Open

cmd/link: remove hard dependency on ld.gold on aarch64 #75074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions src/cmd/link/internal/ld/lib.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1675,27 +1675,8 @@ func (ctxt *Link) hostlink() {
altLinker = "lld"
}

if ctxt.Arch.InFamily(sys.ARM64) && buildcfg.GOOS == "linux" {
// On ARM64, the GNU linker will fail with
// -znocopyreloc if it thinks a COPY relocation is
// required. Switch to gold.
// https://sourceware.org/bugzilla/show_bug.cgi?id=19962
// https://go.dev/issue/22040
altLinker = "gold"

// If gold is not installed, gcc will silently switch
// back to ld.bfd. So we parse the version information
// and provide a useful error if gold is missing.
name, args := flagExtld[0], flagExtld[1:]
args = append(args, "-fuse-ld=gold", "-Wl,--version")
cmd := exec.Command(name, args...)
if out, err := cmd.CombinedOutput(); err == nil {
if !bytes.Contains(out, []byte("GNU gold")) {
log.Fatalf("ARM64 external linker must be gold (issue #15696, 22040), but is not: %s", out)
}
}
}
}

if ctxt.Arch.Family == sys.ARM64 && buildcfg.GOOS == "freebsd" {
// Switch to ld.bfd on freebsd/arm64.
altLinker = "bfd"
Expand Down