Rename databaseName to databaseDriverName #1304
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rename parameter
databaseNametodatabaseDriverNameinNewWithInstance,NewWithDatabaseInstancefunctions and in themigrate objectto clarify its purpose.Why
The current name,
databaseName, may confuse users into thinking it refers to the actual name of their database (e.g. "bank", "test_db"), when in reality it refers to the database driver name (e.g. "postgres", "mysql").This change improves readability and aligns with the
sourceNameparameter, which correctly indicates that it's the name of the source driver.@dhui would you mind reviewing when you get a chance? 🙏