Skip to content

Conversation

EgorSheff
Copy link

Helpfully behavior if you need signature after signing token.
Example: save signature of token to DB after send signed token to user.

@oxisto oxisto requested a review from mfridman July 15, 2025 10:30
@oxisto
Copy link
Collaborator

oxisto commented Jul 24, 2025

@mfridman

@mfridman
Copy link
Member

Seems fine, althouh I think we should update the comment on Signature field to mention that it's populated on parsing or signing

https://github.com/golang-jwt/jwt/blob/b625028f0f645483115e0f0e63029ed36f735147/token.go/#L35

Copy link
Member

@mfridman mfridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit, but otherwise seems reasonble.

@oxisto
Copy link
Collaborator

oxisto commented Sep 11, 2025

Seems fine, althouh I think we should update the comment on Signature field to mention that it's populated on parsing or signing

https://github.com/golang-jwt/jwt/blob/b625028f0f645483115e0f0e63029ed36f735147/token.go/#L35

Can you change that real quick? You should be able to edit this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants