Skip to content

MacOS: Fix embedded screen_get_scale API #109064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Jul 28, 2025

Closes #108949

This ensures that screen_get_scale returns the correct value for the window displaying the embedded content. If the window is moved, screen_get_scale will reflected the current screen.

@stuartcarnie stuartcarnie requested a review from a team as a code owner July 28, 2025 21:07
@bruvzg bruvzg added this to the 4.5 milestone Jul 29, 2025
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the correct data size, it seems to work fine.

@stuartcarnie stuartcarnie force-pushed the 108949_screen_get_scale branch from 37091fe to 5c67739 Compare July 29, 2025 20:00
@stuartcarnie stuartcarnie force-pushed the 108949_screen_get_scale branch from 5c67739 to c62ad8d Compare July 29, 2025 20:06
@Repiteo Repiteo merged commit 6c399bd into godotengine:master Jul 30, 2025
39 of 40 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jul 30, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] Embedded game window return wrong DisplayServer.screen_get_scale()
3 participants