Add WMF video playing (without audio) #108976
Draft
+1,487
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
commented
Jul 25, 2025
|
|
||
| uint8_t *dst = frame->data.ptrw(); | ||
|
|
||
| // WMF Video Processor outputs ARGB32, but Godot expects RGBA8 |
There was a problem hiding this comment.
// WMF Video Processor outputs ARGB32, but Godot expects RGBA8
Look for a more elegant way to swap the pixels.
fire
commented
Jul 25, 2025
| if (denominator > 0) { | ||
| info->fps = (float)numerator / (float)denominator; | ||
| } else { | ||
| info->fps = 30.0f; // Default fallback |
There was a problem hiding this comment.
If we don't know the FPS, maybe we should fail rather than play with the wrong fps.
fire
commented
Jul 25, 2025
Comment on lines
+703
to
+668
| void ResourceFormatLoaderWMF::get_recognized_extensions(List<String> *p_extensions) const { | ||
| p_extensions->push_back("mp4"); | ||
| p_extensions->push_back("avi"); | ||
| p_extensions->push_back("wmv"); | ||
| p_extensions->push_back("mov"); | ||
| p_extensions->push_back("mkv"); | ||
| p_extensions->push_back("webm"); | ||
| p_extensions->push_back("flv"); | ||
| } |
There was a problem hiding this comment.
Maybe the full list of extensions is too extensive.
fire
force-pushed
the
vsk-wmf-4.5
branch
4 times, most recently
from
6926839 to
2256703
Compare
fire
force-pushed
the
vsk-wmf-4.5
branch
3 times, most recently
from
fa03b14 to
bb607cb
Compare
Thanks to the DisplaySweet team https://github.com/DisplaySweet. Implement WMF video resource loading and playback functionality Audio does not work yet. Co-Authored-by: Mark Kuo <starryalley@gmail.com>
fire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is divide and conquer the problem of playing video into only playing video and only playing audio. Then extracting into a container demuxed into video and audio which is then synced.
Thanks to the DisplaySweet team https://github.com/DisplaySweet.
V-Sekai development community focuses on providing social VR functionality for the open source Godot Engine.
Implement WMF video resource loading and playback functionality
Fixes: godotengine/godot-proposals#12864