OpenXR: Work around bug with Meta runtime on 1.0.49 #108869
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Jul 22, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108850
This works around a bug in Meta's OpenXR runtime, which gives incorrect aim pose transforms if the OpenXR version used by the application is 1.0.49 or later. We can remove the workaround once Meta fixes this in their runtime.
This does fix the issue on the Meta Quest 3 in my testing, however, the more important question is if this will cause problems on other runtimes, in particular those that support OpenXR render models (support added in #107388) which is part of OpenXR 1.x.49. Hopefully, they aren't checking the version and features from 1.x.49 will work anyway 🤞
Will need some testing on a variety of OpenXR runtimes