[Web] Make emscriptenThreadPool and godotThreadPool values automatic
#108832
+33
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc. @marcosc90 |
adamscott
force-pushed
the
autodetect-threadpool
branch
from
b0aafec to
a897b49
Compare
bruvzg
reviewed
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Needs testing. I had issues testing the fix on iOS and iPadOS, but I don't think it's related.
Instead of exposing
emscriptenThreadPoolandgodotThreadPoolin export settings, this PR makes it so that it usesnavigator.hardwareConcurrencyas a base, with minimum values.Fixes #108484.
Note
The PR also makes the
Clear persistent databutton actually clear the service worker. Needed to test the fix on mobile platforms.