Added ability to specify editorPath using environment variable (#807) #856
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heya, just checking back in to make sure y'all aren't waiting for anything else from me to get this merged? |
|
No I've just been busy. I got a new job recently and I've been completely swamped. |
|
Aight, cool! No worries then, take your time! Just wanted to ensure I wasn't a bottleneck. Best of luck with the new job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt at any extension coding, so feel free to give me tips if anything seems off.
But I noticed that someone had already reported this issue that I also wanted fixed, so it seemed like a good reason to dip my toes in.
Regex section is based on the setup in vscode-cpptools and seems to do the trick.
Only part I'm unsure about is the section in
debugger_variables.test.ts. Was there a reason for it not callingclean_godot_pathpreviously?