-
-
Notifications
You must be signed in to change notification settings - Fork 202
Adds Various code actions to make refactoring a bit easier #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adds Various code actions to make refactoring a bit easier #853
Conversation
Refractoring variables exports
…tion Extract code to its own function
Interesting idea, I'm not opposed to this. I do have feedback, would you prefer me opening review items or just editing the PR myself? |
Please open review items, as I want to learn this whole process |
@DaviD4Chirino I wrote some review comments just based on reading the diff. I'll have more feedback once I clone this branch and play with the features a bit. |
So uh, my computer broke and i have no idea when i could get it working again, feel free to modify this pull as much as you like, i also had made the two most important code actions i wanted to make, extract function and extract variable. If theres minors error i could still not catch i apologise but i am unable to keep up for at least a month while i fix this shitty computer, I think its good enough for a pull but thats for you to decide |
Yikes, I hope you're back online soon! Yeah I'll see what I can do. Thanks for doing the legwork! |
Hey man, i got a laptop in meantime, have you worked on the code? what do you think? Also sorry about leaving you the work i can get back on it now if that's ok. Also its chatting in the pull request good manners? Is there a discord or something we could talk? I'm fine with this but i wanna make sure i'm leaving messages in the proper manner. |
Yeah I'm available on discord @ daelon if you want to talk directly, that's usually easier than PR comments. I'm in my 3rd week of a new job so I'm a bit swamped and have not had time to work on this yet. I definitely plan to once things settle down a bit. |
ncMwIr84Di.mp4So i made it work, and now that i can do that i could go back and improve extract variables code actions, but i thought it was better to finish this. Also theres a couple things i want to point out,
I could tackle these thing but i wanted your input |
I want add more refactoring, and export options, but right now its good to go and most importantly, for you guys to give me pointers (as its the second extension I've made)
(I closed the other one because i missed some semicolons and i felt ashamed)